move uefi test to run-make #144454
Merged
move uefi test to run-make #144454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-CI
|
This PR modifies cc @jieyouxu There are changes to the cc @jieyouxu The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
@bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jul 25, 2025
move uefi test to run-make try-job: test-various
|
Linking to the zulip discussion for future reference: #t-compiler > testing uefi with run-make? |
nicholasbishop
approved these changes
Jul 25, 2025
jieyouxu
reviewed
Jul 26, 2025
|
@rustbot author |
rustbot
removed
the
S-waiting-on-review
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Also I do still think removing the dependency is a good idea, but I'll leave that to @nicholasbishop once this is merged. |
jieyouxu
approved these changes
Jul 26, 2025
|
@bors r=jieyouxu |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 26, 2025
move uefi test to run-make Turn the `uefi` test into a more standard `run-make` test, and execute it using the `test-various` CI job like before. This is just a straightforward translation of the python code, but using `run-make` to supply the target (hence the 3 separate calls in the docker file). r? `@jieyouxu` cc `@nicholasbishop` try-job: test-various
bors
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup of 10 pull requests Successful merges: - #144359 (add codegen test for variadics) - #144409 (Stop compilation early if macro expansion failed) - #144422 (library/windows_targets: Fix macro expansion error in 'link' macro) - #144430 (tests: aarch64-outline-atomics: Remove hardcoded target) - #144445 (Fix `./x check bootstrap` (again)) - #144453 (canonicalize build root in `tests/run-make/linker-warning`) - #144454 (move uefi test to run-make) - #144464 (Only run bootstrap tests in `x test` on CI) - #144495 (bump cargo_metadata) - #144500 (thread name in stack overflow message) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 26, 2025
move uefi test to run-make Turn the `uefi` test into a more standard `run-make` test, and execute it using the `test-various` CI job like before. This is just a straightforward translation of the python code, but using `run-make` to supply the target (hence the 3 separate calls in the docker file). r? ``@jieyouxu`` cc ``@nicholasbishop`` try-job: test-various
bors
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup of 9 pull requests Successful merges: - #144359 (add codegen test for variadics) - #144409 (Stop compilation early if macro expansion failed) - #144422 (library/windows_targets: Fix macro expansion error in 'link' macro) - #144430 (tests: aarch64-outline-atomics: Remove hardcoded target) - #144445 (Fix `./x check bootstrap` (again)) - #144453 (canonicalize build root in `tests/run-make/linker-warning`) - #144454 (move uefi test to run-make) - #144464 (Only run bootstrap tests in `x test` on CI) - #144495 (bump cargo_metadata) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jul 27, 2025
Rollup of 4 pull requests Successful merges: - #144226 (Do not assert layout in KnownPanicsLint.) - #144385 (Optimize performance by inline in macro hygiene system) - #144454 (move uefi test to run-make) - #144455 (Unify LLVM ctlz/cttz intrinsic generation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 27, 2025
Rollup merge of #144454 - folkertdev:uefi-tests, r=jieyouxu move uefi test to run-make Turn the `uefi` test into a more standard `run-make` test, and execute it using the `test-various` CI job like before. This is just a straightforward translation of the python code, but using `run-make` to supply the target (hence the 3 separate calls in the docker file). r? ```@jieyouxu``` cc ```@nicholasbishop``` try-job: test-various
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn the
uefitest into a more standardrun-maketest, and execute it using thetest-variousCI job like before.This is just a straightforward translation of the python code, but using
run-maketo supply the target (hence the 3 separate calls in the docker file).r? @jieyouxu
cc @nicholasbishop
try-job: test-various